[Stack Switching] Implement resume_throw in the interpreter #7815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Aug 11, 2025
| @@ -844,4 +844,24 @@ | |||
| ) | |||
| ) | |||
| ) | |||
|
|
|||
| (func $never | |||
There was a problem hiding this comment.
How would you feel about upstreaming this to the spec tests?
There was a problem hiding this comment.
Sure, proposed:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward: Add an exception tag to ContData, and throw if
it is set.
With this, the next big spec test passes.
Throwing from the first resumption is not in the spec test, so add that
manually (for us, but I guess not the spec interpreter, this checks
another code path).
This uncovered an existing bug with StackValueNoter. We added one of
these during Resume, to ensure a stack value noting scope always
existed. But we track those by ModuleRunner, so it doesn't help when we
do a cross-module suspend. Just remove that extra logic, and handle the
lack of a scope directly, which makes this all a lot simpler. (This could be
broken out into another PR, but testing it would be tricky by itself.)