Skip to content

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Jan 25, 2023

This is useful for wasm performance (and for size tests, since Emscripten EH makes the binary unnecessarily slow and large).

This is useful for wasm performance and size tests, since Emscripten EH
makes the binary unnecessarily slow and large.
@dschuff dschuff marked this pull request as ready for review January 27, 2023 21:30
@dschuff dschuff requested a review from aheejin January 31, 2023 19:31
@dschuff dschuff merged commit 6a2ec34 into main Feb 2, 2023
@dschuff dschuff deleted the enable-eh branch February 2, 2023 22:12
@dschuff
Copy link
Member Author

dschuff commented Feb 2, 2023

I guess at some point we might want to make this the default, as most wasm runtimes will support exceptions. I imagine this might have already happened with some version of node... do we have any idea which?

@aheejin
Copy link
Member

aheejin commented Feb 2, 2023

What do you mean by "it" in "it happened with some version of node"? Having Wasm EH support? Or supporting it by default without a flag? I just tested with several versions of node on my local machine and they turn on EH support by default (= without a flag) as of v17.5. v17.0 doesn't turn it on by default.

Not sure what you mean by "make this the default".

@MaxGraey
Copy link
Contributor

MaxGraey commented Feb 2, 2023

Wasm exceptions enabled by default in node 17. Current LTS node is 18 so it absolutely ok enable exceptions by default I guess

See https://webassembly.org/roadmap
Screenshot 2023-02-03 at 00 35 11

@aheejin
Copy link
Member

aheejin commented Feb 2, 2023

Hmm my local v17.0 was a nightly version I installed a few years back, so it might be the reason it didn't work..? Anyway, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants