Skip to content

Fix a typo in Flat IR validation logic #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix a typo in Flat IR validation logic #5450

merged 1 commit into from
Jan 25, 2023

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 24, 2023

doVisitFunction does not exist, and we don't have static checking of that
sadly. Could overrides work here..?

@kripken kripken requested a review from tlively January 24, 2023 23:39
tlively
tlively approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, so we just weren't running this verification?

Unfortunately override only works with proper virtual methods, not with the CRTP nonsense we use.

@kripken
Copy link
Member Author

kripken commented Jan 25, 2023

Yes, we were missing this part of the validation. It might matter less than the rest though.

@kripken kripken merged commit 48c8615 into main Jan 25, 2023
@kripken kripken deleted the vacfix branch January 25, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kripken @tlively