Implement prototype v128.load{32,64}_zero instructions #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specified in WebAssembly/simd#237. Since these are just prototypes necessary for benchmarking, this PR does not add support for these instructions to the fuzzer or the C or JS APIs. This PR also renumbers the QFMA instructions that previously used the opcodes for these new instructions. The renumbering matches the renumbering in V8 and LLVM.
aheejin
approved these changes
Aug 1, 2020
test/simd.wast.fromBinary
Outdated
| ) | ||
| (func $f32x4.qfma (param $0 v128) (param $1 v128) (param $2 v128) (result v128) | ||
| (f32x4.qfma | ||
| (drop |
MaxGraey
reviewed
Aug 1, 2020
| V128Load32Zero = 0xfc, | ||
| V128Load64Zero = 0xfd, | ||
|
|
||
| F32x4QFMA = 0xb4, |
Contributor
There was a problem hiding this comment.
0xb4 already used for I32x4DotSVecI16x8:
https://github.com/WebAssembly/binaryen/blob/master/src/wasm-binary.h#L836
Is it correct?
kripken
approved these changes
Aug 3, 2020
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
No extra questions from me aside from those already asked by others.
Member
Author
|
Yes, this is the correct renumbering, although the opcode collision is unintentional. I will shift the dot instruction opcode to use the number used by V8 as well. See https://github.com/WebAssembly/tool-conventions/blob/master/Linking.md#target-features-section for the numbering I am following. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specified in WebAssembly/simd#237. Since these
are just prototypes necessary for benchmarking, this PR does not add
support for these instructions to the fuzzer or the C or JS APIs. This
PR also renumbers the QFMA instructions that previously used the
opcodes for these new instructions. The renumbering matches the
renumbering in V8 and LLVM.