Reland "Link binaryen tools against the dylib" #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure a relative install rpath.
sbc100
approved these changes
Jun 3, 2020
Member
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Presumably we should be doing some post-install testing? But I guess it would be pretty rare that this might break?
Member
Author
|
Yeah, I guess we'd need to do a test that runs it from the installation directory rather than the build directory, so we'd have to change the cmake install prefix. Do you know how we'd figure out what we should set it to on github actions? |
Member
Author
|
Although this CL also sets |
Member
Author
|
Confirmed that CMake no longer updates the rpath during install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #2864
Also ensure a relative install rpath by adding setup to each tool config.
The CMake code is cribbed from LLVM's implementation.