Skip to content

DCE at the end of wasm2js #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

DCE at the end of wasm2js #2574

merged 1 commit into from
Jan 7, 2020

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 6, 2020

By doing so we ensure that our calls to convert wasm
types to JS types never try to convert an unreachable.

Fixes #2558

@kripken kripken requested a review from aheejin January 6, 2020 22:49
aheejin
aheejin approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kripken kripken merged commit 0dab885 into master Jan 7, 2020
@kripken kripken deleted the fix_2558 branch January 7, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheejin aheejin aheejin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm2js -O --emscripten crashes
2 participants
@kripken @aheejin