Skip to content

Conversation

lofcz
Copy link
Member

@lofcz lofcz commented Sep 25, 2022

  • all members must be static
  • can't be instantiated
  • can't be used as a base class
  • can't contain a constructor

Also adds missing LoopChk and BaseChk to InstructionFieldUsage, tests expected to crash no longer have to provide a blank file with expected stdout.

Test 23 is currently failing (point 2 above)

Fixes a bug introduced in #52, see test 25 for details.

@lofcz lofcz requested a review from CallumDev September 25, 2022 19:48
@lofcz lofcz marked this pull request as ready for review October 2, 2022 00:33
Copy link
Contributor

@CallumDev CallumDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the way there, a couple of small changes - and unfortunately I think GetDescription<T> breaks a couple of use cases that I am aware wattlescript is currently being used for.

@CallumDev CallumDev merged commit f70c24d into main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants