Skip to content

Conversation

@fizzi01
Copy link
Contributor

@fizzi01 fizzi01 commented Dec 19, 2025

What do these changes do?

This PR fixes a critical issue where buffered data in StreamReader is lost when upgrading a connection to TLS using StreamWriter.start_tls() or loop.start_tls(), causing the call to hang indefinitely. The issue exists in both asyncio (see python/cpython#142352) and uvloop.

The main focus is to verify and guarantee that any data buffered before upgrading a connection to TLS is not lost and is correctly transferred. These changes are effectively a port of python/cpython#142354 with absolutely no difference, except for the test that creates a TCP server, establishes a connection, buffers data, performs a TLS upgrade, and verifies that all messages (both pre-upgrade and post-upgrade) are received correctly.

Are there changes in behavior for the user?

No.

Is it a substantial burden for the maintainers to support this?

Nope.

Related issue number

Fixes #102

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Vizonex
Copy link
Owner

Vizonex commented Dec 20, 2025

@fizzi01 If the unittests fail know that it's caused by a rounding bug in uvloop and winloop and possibly libuv due to how it does math for getting timeouts.

@Vizonex Vizonex self-requested a review December 20, 2025 04:02
@Vizonex
Copy link
Owner

Vizonex commented Dec 20, 2025

@fizzi01 Thanks for the pull request btw. We don't get contributors here very often. I'll probably wind up optimizing this code in a later update since I've been trying to optimize the pure python portions for better performance.

@Vizonex Vizonex merged commit 544a18c into Vizonex:main Dec 20, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start_tls() loses buffered data and doesn't work when upgrading a stream

2 participants