Skip to content

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented May 23, 2025

Migrate to 0.12, they said.
It will be fun, they said.

Special thanks to @lolgab, who trailblazed this back in #3250

What this does:

  • bumps mill to 0.12.14
  • migrates build configuration files to .mill.scala, along with the new syntax
  • bumps mill-scalafix to 0.5.1
    • a new, dedicated scalafix configuration has been added specifically for modules which are cross compiled against Scala 2.12, 2.13 and 3 (such as runner or test-runner)
    • RemoveUnused has been enabled for Scala 3
      • a side effect is that I had to do some funny workarounds with imports because of an obscure linting bug that's present in Scala 3.3.6, but not in 3.7 (and we do cross-compile with scalafix)
      • just the 0.5.1 introduced a load of changes, and bringing the configuration consistent for all cross-compiled options was funny, the steps are in separate commits
  • bumps mill-native-image and mill-native-image-upload to 0.1.31-1
  • a myriad of smaller things, hacks and workarounds

@Gedochao Gedochao force-pushed the update/mill-0.12 branch 3 times, most recently from d6709e0 to 929264a Compare May 23, 2025 11:50
@Gedochao Gedochao changed the title [WIP] [WIP] Bump mill to 0.12 May 23, 2025
@Gedochao Gedochao force-pushed the update/mill-0.12 branch 11 times, most recently from 69a8be1 to eea6725 Compare May 27, 2025 05:06
@Gedochao Gedochao changed the title [WIP] Bump mill to 0.12 Bump mill to 0.12 May 27, 2025
@Gedochao Gedochao mentioned this pull request May 27, 2025
2 tasks
@Gedochao Gedochao marked this pull request as ready for review May 27, 2025 10:36
@Gedochao Gedochao requested a review from tgodzik May 27, 2025 10:36
@lolgab
Copy link
Contributor

lolgab commented May 27, 2025

You can add me as co-author in the final merge with the following:

Co-authored-by: Lorenzo Gabriele <[email protected]>

@Gedochao Gedochao force-pushed the update/mill-0.12 branch from 25ee82e to e136064 Compare May 28, 2025 11:25
@Gedochao
Copy link
Contributor Author

Rebased on top of main to solve conflicts + cleaned the commits structure a bit.

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was a lot of changes! Great work! I think it's mostly done, I just reported some smaller issues and have some questions

@Gedochao Gedochao force-pushed the update/mill-0.12 branch 5 times, most recently from c60d3f0 to d058873 Compare May 29, 2025 05:58
@Gedochao Gedochao force-pushed the update/mill-0.12 branch from d058873 to db3a972 Compare May 29, 2025 06:09
@Gedochao Gedochao requested a review from tgodzik May 29, 2025 06:09
@Gedochao Gedochao force-pushed the update/mill-0.12 branch from db3a972 to 3cff70a Compare May 29, 2025 06:16
@Gedochao Gedochao force-pushed the update/mill-0.12 branch from 3cff70a to 58c73fa Compare May 29, 2025 06:17
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only some minor comments for future consideration. Great work!

@Gedochao Gedochao force-pushed the update/mill-0.12 branch from 58c73fa to ccbf2cc Compare May 29, 2025 12:26
@Gedochao Gedochao enabled auto-merge (squash) May 29, 2025 15:05
@Gedochao Gedochao merged commit 1faa384 into VirtusLab:main May 30, 2025
162 of 165 checks passed
@Gedochao Gedochao deleted the update/mill-0.12 branch May 30, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants