-
Notifications
You must be signed in to change notification settings - Fork 148
Bump mill
to 0.12
#3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mill
to 0.12
#3691
Conversation
d6709e0
to
929264a
Compare
69a8be1
to
eea6725
Compare
You can add me as co-author in the final merge with the following:
|
25ee82e
to
e136064
Compare
Rebased on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was a lot of changes! Great work! I think it's mostly done, I just reported some smaller issues and have some questions
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/options/src/main/scala/scala/build/info/ScopedBuildInfo.scala
Outdated
Show resolved
Hide resolved
c60d3f0
to
d058873
Compare
d058873
to
db3a972
Compare
db3a972
to
3cff70a
Compare
Co-authored-by: Lorenzo Gabriele <[email protected]>
Co-authored-by: Lorenzo Gabriele <[email protected]>
3cff70a
to
58c73fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM only some minor comments for future consideration. Great work!
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Godzik <[email protected]>
58c73fa
to
ccbf2cc
Compare
Migrate to 0.12, they said.
It will be fun, they said.
Special thanks to @lolgab, who trailblazed this back in #3250
What this does:
mill
to 0.12.14.mill.scala
, along with the new syntaxmill-scalafix
to 0.5.1scalafix
configuration has been added specifically for modules which are cross compiled against Scala 2.12, 2.13 and 3 (such asrunner
ortest-runner
)RemoveUnused
has been enabled for Scala 3scalafix
)mill-native-image
andmill-native-image-upload
to 0.1.31-1