Ensure test source directives with test scope equivalents are migrated by fix to project.scala
#3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/fix-test-dependencies
branch
from
6faec2d to
89b6179
Compare
Gedochao
commented
Jan 16, 2025
modules/integration/src/test/scala/scala/cli/integration/FixBuiltInRulesTestDefinitions.scala
Show resolved
Hide resolved
tgodzik
reviewed
Jan 16, 2025
modules/integration/src/test/scala/scala/cli/integration/FixBuiltInRulesTestDefinitions.scala
Outdated
Show resolved
Hide resolved
Gedochao
force-pushed
the
maintenance/fix-test-dependencies
branch
from
89b6179 to
56e67cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3410
Fixes #3409 (actually already works as expected, with the line length limit equal to 100 characters atm; a test is added in this PR)
Requires:
fixfor single-file projects #3422So the tricky part is that, when migrating directives from test sources to the
project.scalaconfiguration file, we can only migrate the ones which have test scope equivalents.//> using dephas an equivalent in//> using test.dep, but//> using scalahas none.So the directives with no equivalents have to stay where they are, otherwise behaviour will change.