Go mod and sprig bump #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #21 Signed-off-by: Paweł Prażak <[email protected]>
- the might be subtle behavioural changes, for details see: https://github.com/Masterminds/sprig/releases/tag/v3.0.0 Fixes #23 Signed-off-by: Paweł Prażak <[email protected]>
tumevoiz
requested changes
Jul 14, 2020
|
|
||
| .PHONY: init | ||
| init: ## Initializes this Makefile dependencies: dep, golint, staticcheck, checkmake | ||
| init: ## Initializes go tools this Makefile uses: golint, staticcheck, goimports, checkmake |
There was a problem hiding this comment.
init: ## Initializes go tools: golint, staticcheck, goimports, checkmake
Contributor
Author
There was a problem hiding this comment.
less info = more sense? ;)
There was a problem hiding this comment.
okay, so I think you forgot a comma between go tools and this Makefile uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23