This repository was archived by the owner on Aug 4, 2025. It is now read-only.
fix bug when defining descriptor types #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we tried to add backward compatibility on bndb files, we added a
function `get_type`, but the result of
```python
bv.get_code_refs_for_type("EFI_PEI_NOTIFY_DESCRIPTOR")
```
and
```
bv.get_code_refs_for_type(bv.types("EFI_PEI_NOTIFY_DESCRIPTOR")
```
is different.
Fixed this bug by not defining descriptor types on existing bndb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tried to add backward compatibility on bndb files, we added a function
get_type, but the result ofand
is different.
The latter is empty and thus fails to define those descriptors.
Fixed this bug by not supporting defining descriptor types on existing bndb anymore. (Consider supporting this in the native rewriting version)