`S`/`cc` doesn't auto indent on empty line

[alnorris]

When your in Normal mode and your on an empty line and the cursor is at the very left, pressing 'S' in normal Vim auto indents the line and goes into insert mode, but VS Vim doesn't seem to indent at all.

Technical details:

• VSCode Version: 1.6.1
• VsCodeVim Version: 0.4.0
• OS: OSX El capitan

What happened:

• Typing cc when cursor is at col 0 and in block on empty line: Jumping to input mode, but won't indent correctly
• Typing cc when cursor is at col 2 (or any col): Removes line and ends up at col 0 with no indentation
• Typing cc when cursor is at col 0 but there is valid code on line that is inside a block: Removes line as it should do, but cursor ends at col 0 with trailing whitespace
• Typing cc when cursor is at col >2 (in block, line with valid code, cursor on code): Removes line of code and indents correctly ✅

Here all of those scenarios in a GIF (with tab width of 3 instead of 2)

Contributed by @lumio at #1828.

What did you expect to happen: Typing cc will always clear the line, indents it and cursor jumps to end of line.

How to reproduce it: See above, but typically typing cc on different col positions.

[rebornix]

Nice catch, if the cursor is at somewhere between first char or last char, S works as expected but doesn't work if it's at the beginning of the file.

[rebornix]

Not sure for what reason cursor updating in commands which invoke delete no longer works, I saw this commit change 3dad7ca#diff-7addcd1a8a241060a73b1fe4abb39960R1269 so @johnfn might have an idea about that.

I take a quick look but now I'm confused, take S for example, if we want to control the cursor position after running delete operator, how can we do that? delete operator is now a postponed action.

[johnfn]

@rebornix we use PositionDiffs now. We have a "beginning of line" position diff that just tells the cursor to go to the beginning of the line after the transformation is applied. We use that a few times...

[Chillee]

This problem is fixable once the "reindent a selection" command is added, per microsoft/vscode#19847 (comment)

[xiluo58]

Seems dd O works perfectly for me.
Is it possible to remap cc to dd O?

[Chillee]

@xiluo58 That's an interesting idea actually. To be clear to anybody who was confused as me, he's suggesting ddO.

[knpwrs]

That works for me!

    "vim.insertModeKeyBindings": [{
        "before": ["j", "k"],
        "after": ["<Esc>"]
    }, {
        "before": ["c", "c"],
        "after": ["d", "d", "O"]
    }],

It would still definitely be nice to see the default behavior fixed.

EDIT: Actually it seems like this doesn't work, seeing as though it's an insert mode key binding. I tried otherModesKeyBindings and it doesn't seem to work there.