[DS-refactor-table-and-api] refactor: Domain:Character API 구현 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
언리얼에서 요청한 API 양식에 맞춰 구현 추가된 기능: - Embeddable로 CustomInfo 클래스 구현, 해당 객체가 실제 캐릭터 정보에 대한 값을 가짐 - UserCharacter에 대해서 API refactoring
변경된 점: - Jpa의 배열 저장을 위한 Converter 클래스를 하나의 패키지 아래에 저장
기존 도메인의 API를 refactoring한 결과 생긴 TestCode 오류를 해결
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
정보
제목
refactor: Domain:Character API 구현
내용
언리얼에서 요청한 API 양식에 맞춰 구현
추가된 기능:
체크 리스트
💯 완료
🎉 수고 하셨습니다!! 🚀
🌈 코드에 기여함을 언제나 감사합니다.
PR 작업한 결과에 대하여 모든 코드는 공유, 배포, 수정, 복사 및 재배포 될 수 있음을 확인합니다.