feat: better handling for synced_block feature in Notion connector #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to Sharepoint inheriting Onedrive, we originally had user_pname required. But it isn't really required. It's actually not even used unless the User user username/password as their form of Auth which is not recommended by Microsoft. SharepointConnectionConfig inherits from OnedriveConnectionConfig , which is where the use and declaration of this arg is made. With the changes in the PR, we override the arg to be Optional Also updated the vertexai model which was deprecated.
bryan-unstructured
approved these changes
May 13, 2025
According to Google API documentation, the `webContentLink` and `exportLink` are intended to be used in browsers, not by scripts. This leads to a situation when e.g. `webContentLink` redirects to the Google'a auth login page, which is downloaded and sent to partition. Instead of that we should use the `googleclient`'s methods, that [call the Google Drive appropriate APIs to perform download/export operations](https://developers.google.com/workspace/drive/api/guides/manage-downloads#python): - `get_media` to download standalone files - `export` to export Google Workspace native files (Google Docs, Google Slides, Google Sheets) to corresponding office files (docx, pptx, xlsx, accordingly) - `download` to export Google Workspace native files for files that result with >10MB size - this operation uses LRO (Long Running Operation) mechanism described [here](https://developers.google.com/workspace/drive/api/guides/long-running-operations)
Co-authored-by: Filip Knefel <[email protected]> Co-authored-by: Filip Knefel <[email protected]>
- cap redis client version to avoid breaking uploader plugin - fixed azure and s3 e2e test script so that they no longer report error
fix error in google drive E2E test "Error in downloader: 512: [ModuleNotFoundError] No module named 'tenacity'" --------- Co-authored-by: Paweł Kmiecik <[email protected]>
Improve `precheck` method of Confluence's Indexer. Validate that each space provided in configuration can be accessed, raise exception if at least one of them can't. --------- Co-authored-by: Rob Roskam <[email protected]> Co-authored-by: Filip Knefel <[email protected]>
Co-authored-by: Filip Knefel <[email protected]>
|
Closing this PR and reopening another one, something did not merger right after rebase it was faster this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is @teddysupercuts contribution from his fork.
Original PR can be found here.
Re-opening this PR from origin so that our tests work correctly.