fix: add 'in_trash' field to Notion block, database, and page models #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this also get an update to the changelog? That'll prevent the CI linters from passing. |
|
@rbiseck3 done - I tried to follow the existing format as closely as possible |
jakub-sandomierz-deepsense-ai
requested review from
rbiseck3 and
potter-potter
hardchor
force-pushed
the
notion-in-trash-property
branch
from
bf3a771 to
c83ff4a
Compare
|
Sorry, I think the changelog needs to be updated one more time to pull in changes that had since been merged in. |
rbiseck3
reviewed
Oct 15, 2024
| ### Fixes | ||
|
|
||
| * **Update Sharepoint Creds and Expected docs** | ||
| - **Update Sharepoint Creds and Expected docs** |
There was a problem hiding this comment.
Looks like something updated all of these, can we limit the changes to the changelog in this PR?
|
Closing in favor of new PR: #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56