Make analytics module an optional dependency. #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surfnerd
force-pushed
the
develop-analytics-optional-dep
branch
from
fb0b114 to
4a0ea68
Compare
mbargiel
reviewed
Mar 15, 2021
com.unity.ml-agents/Tests/Editor/Unity.ML-Agents.Editor.Tests.asmdef
Outdated
Show resolved
Hide resolved
chriselion
reviewed
Mar 15, 2021
chriselion
reviewed
Mar 15, 2021
…methods that can be compiled out.
chriselion
reviewed
Mar 15, 2021
chriselion
reviewed
Mar 15, 2021
chriselion
approved these changes
Mar 15, 2021
Co-authored-by: Chris Elion <[email protected]>
… the analytics module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Make analytics module an optional dependency and add tests to make sure that works.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Addresses #5064
Types of change(s)
Checklist