Skip to content

fix sample code for custom SideChannel #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Adding example project hint to Discrete Action Mask section
merged 3 commits into from
Sep 9, 2020
Merged

fix sample code for custom SideChannel #4466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
767f971
fix sample code for custom SideChannel
Sep 9, 2020
1ec6113
update python code too
Sep 9, 2020
f7f0138
changelog
Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.ml-agents/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ your trainer configuration to do so. (#4448)
#### com.unity.ml-agents (C#)
- The package dependencies were updated to include the built-in packages that are used also. (#4384)
#### ml-agents / ml-agents-envs / gym-unity (Python)
- Fixed the sample code in the custom SideChannel example. (#4466)

## [1.3.0-preview] - 2020-08-12

Expand Down
11 changes: 6 additions & 5 deletions docs/Custom-SideChannels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public class StringLogSideChannel : SideChannel
ChannelId = new Guid("621f0a70-4f87-11ea-a6bf-784f4387d1f7");
}

public override void OnMessageReceived(IncomingMessage msg)
protected override void OnMessageReceived(IncomingMessage msg)
{
var receivedString = msg.ReadString();
Debug.Log("From Python : " + receivedString);
Expand Down Expand Up @@ -209,13 +209,14 @@ env = UnityEnvironment(side_channels=[string_log])
env.reset()
string_log.send_string("The environment was reset")

group_name = env.get_agent_groups()[0] # Get the first group_name
group_name = list(env.behavior_specs.keys())[0] # Get the first group_name
group_spec = env.behavior_specs[group_name]
for i in range(1000):
step_data = env.get_step_result(group_name)
n_agents = step_data.n_agents() # Get the number of agents
decision_steps, terminal_steps = env.get_steps(group_name)
# We send data to Unity : A string with the number of Agent at each
string_log.send_string(
"Step " + str(i) + " occurred with " + str(n_agents) + " agents."
f"Step {i} occurred with {len(decision_steps)} deciding agents and "
f"{len(terminal_steps)} terminal agents"
)
env.step() # Move the simulation forward

Expand Down