Skip to content

Moving domain randomization to C# #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Jun 12, 2020
Merged

Moving domain randomization to C# #4065

merged 49 commits into from
Jun 12, 2020

Conversation

@andrewcoh
Copy link
Contributor

@andrewcoh andrewcoh commented Jun 3, 2020 •
edited
Loading

Proposed change(s)

Opening this now for visibility and comments on cleaning up the C# code from the toolkit pod.

TODO:

  • Sending seeds from python
  • Implement multirangeuniform sampler
  • tests C# tests
  • Decide what to do about 'gravity'
  • Update parameter conversion script

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
andrewcoh
andrewcoh commented Jun 3, 2020
View reviewed changes
ervteng
ervteng reviewed Jun 3, 2020
View reviewed changes
ervteng
ervteng reviewed Jun 3, 2020
View reviewed changes
vincentpierre
vincentpierre reviewed Jun 3, 2020
View reviewed changes
vincentpierre
vincentpierre reviewed Jun 5, 2020
View reviewed changes
@andrewcoh andrewcoh marked this pull request as ready for review June 5, 2020 19:29
ervteng
ervteng reviewed Jun 12, 2020
View reviewed changes
ervteng
ervteng reviewed Jun 12, 2020
View reviewed changes
ervteng
ervteng approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹 - one minor comment but looks good

chriselion
chriselion reviewed Jun 12, 2020
View reviewed changes
@andrewcoh andrewcoh merged commit 20527d1 into master Jun 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-sampler-refactor branch June 12, 2020 23:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@ervteng ervteng ervteng approved these changes

@chriselion chriselion chriselion approved these changes

@vincentpierre vincentpierre vincentpierre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@andrewcoh @CLAassistant @ervteng @chriselion @vincentpierre @cypres