-
Notifications
You must be signed in to change notification settings - Fork 322
DOCS: How to use processors #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did my first pass on the PR. Please fix the note formatting and replace the placeholder image alt text with something more descriptive. Also, there are quite a few sentences written in passive voice—please rewrite them in active voice where appropriate. You can refer to the Unity style guide for reference: https://docs-style-guide.unity.com/style/use-active-voice.
Packages/com.unity.inputsystem/Documentation~/HowToApplyProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/ProcessorTypes.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/ProcessorTypes.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/HowToApplyProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/HowToApplyProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
|
||
 | ||
|
||
Note that the Bindings can contain input values with very different ranges. In that case, a Scale Processor on the Bindings can help preprocess the values before clamping them (Processors on Actions are applied after Processors on Bindings). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, a Scale Processor on the Bindings can help preprocess the values before clamping them (Processors on Actions are applied after Processors on Bindings).
I think it would be good to have an example or expand an existing one to show examples of order of execution of processors. Always better to have an example than saying it in words IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a specific example in mind?
…sors.md Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
…sors.md Co-authored-by: lilisha-unity <[email protected]>
…sors.md Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Co-authored-by: lilisha-unity <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2171 +/- ##
========================================
Coverage 65.44% 65.44%
========================================
Files 367 367
Lines 53505 53505
========================================
Hits 35019 35019
Misses 18486 18486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished my review with some suggestions.
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/Documentation~/UsingProcessors.md
Outdated
Show resolved
Hide resolved
Co-authored-by: lilisha-unity <[email protected]>
…es/InputSystem into docs-processors
Description
This adds more documentation on how to use processors.
Testing status & QA
No testing
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: