Skip to content

Conversation

@ekcoh
Copy link
Collaborator

@ekcoh ekcoh commented Jun 23, 2024

Description

Fix for ISXB-927 which ignore platform-specific feature flags relating to Windows Gaming Input when entering play-mode on non-Windows platforms.

Changes made

Excludes code reading and sending IOCTL command when WGI feature flag is explicitly set on non-Windows platforms instead of generating error messages about failed IOCTL on platforms where there is no other possible outcome than failed IOCTL result.

Removes obsolete Windows Gaming Input feature flag that should have been removed already when original WGI support was added since it was superseded by PlayerSettings.windowsGamepadBackendHint

Testing

No automated tests added at this point.

Risk

Small risk.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…ows Gaming Input when entering play-mode on non-Windows platforms.
@ekcoh ekcoh requested review from Pauliusd01 and ritamerkl June 23, 2024 13:14
Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I did not test it though, I think it is sufficient if Paulius approves.

@ekcoh ekcoh requested review from stefanunity and removed request for Pauliusd01 June 24, 2024 12:25
@ekcoh ekcoh requested a review from ritamerkl June 25, 2024 09:01
@ekcoh ekcoh changed the title FIX: ISXB-927 Ignore platform-specific feature flags relating to Windows Gaming Input when entering play-mode on non-Windows platforms. FIX: ISXB-927 Ignore platform-specific feature flags relating to Windows Gaming Input on all platforms. (Obsolete) Jun 25, 2024
@ekcoh ekcoh merged commit 29cde6c into develop Jun 26, 2024
@ekcoh ekcoh deleted the isxb-927-feature-flag-fix-wgi branch June 26, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants