Skip to content

Making both Clear and DisposeAsyncCore methods virtual #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2022
Merged

Making both Clear and DisposeAsyncCore methods virtual #108

merged 3 commits into from
Mar 18, 2022

Conversation

@Arash-Sabet
Copy link
Contributor

@Arash-Sabet Arash-Sabet commented Mar 18, 2022

This PR closes #107 after the merge. Summary of changes:

  • Making both Clear() and DisposeAsyncCore() virtual methods
  • Update the document
  • Update the example project
  • Update the build pipeline's SDK

@Arash-Sabet Arash-Sabet added enhancement New feature or request ci/cd labels Mar 18, 2022
@Arash-Sabet Arash-Sabet self-assigned this Mar 18, 2022
@Arash-Sabet Arash-Sabet merged commit 50fa3bb into main Mar 18, 2022
@Arash-Sabet Arash-Sabet deleted the 107-making-both-clear-and-disposeasynccore-virtual branch March 18, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Arash-Sabet Arash-Sabet

Labels

ci/cd enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Making both Clear() and DisposeAsyncCore() virtual

2 participants

@Arash-Sabet