Skip to content

Conversation

Reinis-FRP
Copy link
Contributor

@Reinis-FRP Reinis-FRP commented Apr 3, 2025

Motivation

Funding proposal script was breaking when passing decimal amounts.

Summary

Uses ethers parser to convert the funding amount in the admin proposal script.

Details

There is a error on simulation against a local forked node:

eth_getBlockByNumber

  Invalid JSON-RPC response's result.
  
  Errors: Invalid value undefined supplied to : RpcBlockWithTransactions | null/totalDifficulty: QUANTITY

This can be fixed by upgrading hardhat, but unfortunately it is not compatible with @defi-wonderland/smock that would break the testing. Hence, this PR does not include the hardhat upgrade and must be run locally (yarn upgrade hardhat) before simulating the fork tests.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

Issue(s)

Fixes #XXXX

Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
@Reinis-FRP Reinis-FRP merged commit 9dcde67 into master Apr 3, 2025
22 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis-frp/gas-rebate-funding-2024 branch April 3, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants