Skip to content

fix(framework): avoid ResizeObserver loop limit exceeded error #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix(framework): avoid ResizeObserver loop limit exceeded error #6934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/base/src/delegate/ResizeHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ const observedElements = new Map<HTMLElement, Array<ResizeObserverCallback>>();
const getResizeObserver = () => {
if (!resizeObserver) {
resizeObserver = new window.ResizeObserver(entries => {
entries.forEach(entry => {
const callbacks = observedElements.get(entry.target as HTMLElement);
// Callbacks could be async and we need to handle returned promises to comply with the eslint "no-misused-promises" rule.
// Although Promise.all awaits all, we don't additonal task after calling the callbacks and should not make any difference.
callbacks && Promise.all(callbacks.map((callback: ResizeObserverCallback) => callback()));
window.requestAnimationFrame(() => {
entries.forEach(entry => {
const callbacks = observedElements.get(entry.target as HTMLElement);
// Callbacks could be async and we need to handle returned promises to comply with the eslint "no-misused-promises" rule.
// Although Promise.all awaits all, we don't await the additional task after calling the callbacks and should not make any difference.
callbacks && Promise.all(callbacks.map((callback: ResizeObserverCallback) => callback()));
});
});
});
}
Expand Down