-
Notifications
You must be signed in to change notification settings - Fork 75
[FIX] Use Node's native https instead of spdy #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@henriquemattos Thanks a lot for your contribution. Note: This PR is a breaking change and would also drop HTTP/2 support but ensure HTTPS is working again. |
|
I see your point, @flovogt . Thank you for the feedback. I see HTTP/2 in development environment as a “nice-to-have” feature, while SSL is, at least for Firefox, a “must-have”. The default settings of the browser uses https even for localhost. Besides, changing the protocol on the frontend would require a CORS, Proxy or change to the backend too. Based on your comment, I don’t understand what are the next steps?! kind regards, |
|
Thanks again for your contribution. We are currently discussing several options in the team on how to proceed with HTTPS support in UI5 CLI. Since this is a breaking change, we are thinking of actually going one step further and replacing express with connect. This would allow us to use the native Node.js HTTP/2 server directly and also solve this issue. We plan major changes to the UI5 Server in UI5 CLI v5 and never made great use of the APIs express provides over connect.
@henriquemattos I'm not able to reproduce this with Firefox 1.145. Could you share some details or documentation on this? The current documentation on Secure Context classifies localhost as "potentially trustworthy", even over HTTP. In my test, I could use for example the Clipboard API on |
|
Thanks for the update, @RandomByte . As for Firefox, I use the Developer Edition and somehow it came with the HTTPS-Only mode enabled. This was becoming a hassle not only for my localhost, but acccessing my router's IP address previously. |
|
I see, thanks. We hope we can provide a solution for current Node.js versions in UI5 CLI v5, one way or another. |
|
In the meantime, do you think would be possible to apply my solution via middleware? I mean, every time I update Node modules, I have to reimplement the workaround locally (as I’m already developing in Node v24 for the next quarter). |
Using native
httpsfrom NodeJS instead of SPDY, which is not supported by Node >= 24.According to NodeJS Releases, “v22 is about to enter Maintenance and v24 is about to become Active”. Unfortunately, this is a breaking change for UI5 CLI
servewhen using--h2, since we usespdy. According to the code comments, we usespdybecause of Node v8.4.0 😬.Tested the upgrade using Firefox Developer Edition (latest) on macOS 26 and NodeJS v24.9.0 with:
Fixes: #327
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist