Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 30, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 30, 2025 17:14
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds polyfills for the simplified TryParse overloads introduced in .NET 7.0 for DateTime and DateTimeOffset types. These overloads accept a string and an IFormatProvider without requiring explicit DateTimeStyles parameters.

  • Adds DateTime.TryParse(string?, IFormatProvider?, out DateTime) polyfill
  • Adds DateTimeOffset.TryParse(string?, IFormatProvider?, out DateTimeOffset) polyfill

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
PolyShim/Signatures.md Updated documentation to reflect the addition of 2 new TryParse method signatures and incremented total member count from 211 to 213
PolyShim/Net70/DateTime.cs Implements the .NET 7.0 DateTime.TryParse polyfill by delegating to the existing overload with DateTimeStyles.None
PolyShim/Net70/DateTimeOffset.cs Implements the .NET 7.0 DateTimeOffset.TryParse polyfill by delegating to the existing overload with DateTimeStyles.None

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 151a670 into master Nov 30, 2025
11 checks passed
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (a8ce085) to head (2a0c408).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #61   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants