Skip to content

Allow using baseUrl, paths and rootDirs options in tsconfig,json #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 13, 2016
Merged

Allow using baseUrl, paths and rootDirs options in tsconfig,json #996

merged 6 commits into from
Jul 13, 2016

Conversation

guncha
Copy link
Contributor

@guncha guncha commented Jul 7, 2016

This is largely based on the work @laurelnaiad did in #849. I mainly just upgraded ntypescript and fixed a few things that broke along the way as well ensured that the baseUrl and rootDirs get converted to absolute paths.

laurelnaiad and others added 6 commits February 12, 2016 13:36
Add the above as valid tsconfig.json properties.

Note: this change does not necessarily make these properties functional, it
simply allows them to be passed to the transpiler.

`baseUrl` and `paths` seem to work. `rootDirs` has not been verified and
might not be functioning (at least on cur. typescript@next).

TODO: this does not yet deeply validate the paths and rootDirs properties.
@zaaack
Copy link

zaaack commented Jul 8, 2016

+1

@guncha
Copy link
Contributor Author

guncha commented Jul 13, 2016

@basarat, this is the last missing piece to let my team migrate over to using reasonable import paths and I'm wondering if you have any concerns about the PR. If so, please let me know and I can address them.

@basarat
Copy link
Member

basarat commented Jul 13, 2016

I'm wondering if you have any concerns about the PR

None. I trust you 🌹

@basarat basarat merged commit d8a7348 into TypeStrong:master Jul 13, 2016
@basarat
Copy link
Member

basarat commented Jul 14, 2016

Released with 10.1.0 as a minor version upgrade 🌹

@guncha
Copy link
Contributor Author

guncha commented Jul 14, 2016

Thank you, I appreciate it.

@tomitrescak
Copy link

You are stars! Thanks! 👏

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants