Allow using baseUrl, paths and rootDirs options in tsconfig,json #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the above as valid tsconfig.json properties. Note: this change does not necessarily make these properties functional, it simply allows them to be passed to the transpiler. `baseUrl` and `paths` seem to work. `rootDirs` has not been verified and might not be functioning (at least on cur. typescript@next). TODO: this does not yet deeply validate the paths and rootDirs properties.
|
+1 |
|
@basarat, this is the last missing piece to let my team migrate over to using reasonable import paths and I'm wondering if you have any concerns about the PR. If so, please let me know and I can address them. |
None. I trust you 🌹 |
|
Released with |
|
Thank you, I appreciate it. |
|
You are stars! Thanks! 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely based on the work @laurelnaiad did in #849. I mainly just upgraded ntypescript and fixed a few things that broke along the way as well ensured that the baseUrl and rootDirs get converted to absolute paths.