Can import autocompletion not insert semicolon?

[blakeembrey]

I don't really use semi-colons, can we detect this on the line and if a semicolon is missing skip inserting it?

[basarat]

I don't really use semi-colons

Now I don't feel so bad about my lack of using them sometimes (or maybe I should be cause that means I'm inconsistent). Up for grabs 🌹

Implementer guidance

Recently work was done to make import autocomplete preserve whitespace #805 . Similar approach should be taken here 🌹

[blakeembrey]

FWIW, I love that you do this 👍 You leave fantastic comments for the next person to come along!

[AugustSaintFreytag]

A +1 from me, it should preserve every allowed code style. The auto-complete system could either read an existing linter style or use a style option from the tsconfig.

[lierdakil]

@ApricumMedia, there is no style option in tsconfig, is there? https://www.typescriptlang.org/docs/handbook/compiler-options.html

Besides, since we're using tsserver, for autocompletion, built-in formatting, etc, I feel like this issue belongs to the TypeScript repo, and hey, look, here it is.

Also, to be fair, we do support non-standard formatCodeOptions setting in tsconfig.json. It doesn't support semicolon behaviour configuration though.

For the sake of completeness, here is the schema of formatCodeOptions (taken from tsserver protocol description, may change depending on your TypeScript version):

    interface FormatCodeSettings {
        baseIndentSize?: number;
        indentSize?: number;
        tabSize?: number;
        newLineCharacter?: string;
        convertTabsToSpaces?: boolean;
        indentStyle?: "None" | "Block" | "Smart";
        insertSpaceAfterCommaDelimiter?: boolean;
        insertSpaceAfterSemicolonInForStatements?: boolean;
        insertSpaceBeforeAndAfterBinaryOperators?: boolean;
        insertSpaceAfterConstructor?: boolean;
        insertSpaceAfterKeywordsInControlFlowStatements?: boolean;
        insertSpaceAfterFunctionKeywordForAnonymousFunctions?: boolean;
        insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis?: boolean;
        insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets?: boolean;
        insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces?: boolean;
        insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces?: boolean;
        insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces?: boolean;
        insertSpaceAfterTypeAssertion?: boolean;
        insertSpaceBeforeFunctionParenthesis?: boolean;
        placeOpenBraceOnNewLineForFunctions?: boolean;
        placeOpenBraceOnNewLineForControlBlocks?: boolean;
    }

In the meantime, consider using some sort of 'save-on-prettify' tool with the prettifier you like. We're using prettier and found it to be rather nice.

[finscn]

any news?