Skip to content

refactor entrypoints #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Jan 11, 2023

  • refactor the way to create a blocknote editor
  • also removed react-icons from "core". "core" module is now completely without React dependency. We'll need to review the way defaultCommands work and icons are added in the react package, as it's not really nice now though

@vercel
Copy link

vercel bot commented Jan 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
blocknote ✅ Ready (Inspect) Visit Preview Jan 11, 2023 at 0:46AM (UTC)

@YousefED YousefED merged commit 3f88072 into react-separation Jan 11, 2023
matthewlipski added a commit that referenced this pull request Jan 18, 2023
* upgrade to react 18

* Maybe fixed React error in build

* Added early implementation of bubble menu & editor in separate react package

* Moved all hyperlink menus to react package

* Major structural overhaul to menu factories

* Added suggestions menu factory with new (hopefully final) factory structure

* Refactored bubble menu code to use improved factory structure

* Changes to bubble menu code and documentation

* Changes to bubble menu code and documentation

* General improvements, mostly to bubble and hyperlink menus

* comments after call

* Split bubble menu props into init & update props
Moved animation delay timeout to bubble menu plugin

* clean up packaging

* fix react error

* Changed bubble menu plugin view back to use a separate class

* Split hyperlink menu props into init & update props

* Changed hyperlink menu plugin view to use a separate class

* fix gitignore

* fix tsconfig

* Major cleanup for bubble menu factory code

* Major cleanup for hyperlink menu factory code

* Minor fixes

* Converted suggestion plugin view to use a class

* Changed editor example to use React as before

* Improved file structure and minor tweaks

* Minor refactor

* Fixed hyperlink menu behaviour

* Separated drag handle UI elements to react package

* Separated drag handle UI elements to react package

* Minor improvements

* fix lint

* refactor entrypoints (#77)

* refactor entrypoints

* fix packages

* fix build

* move some more files / remove root.module.css

* Fixed hyperlink edit menu bugs

* re-add font

* Removed bubble menu animation update delay hack

* Changed bubble menu placement to be at the start of the selection bounding box

* Fixed hyperlink menu naming inconsistencies

* Refactored block/drag menu to use one factory and separate view class

* Fixed bubble menu sometimes attempting to hide when already hidden

* Fixed drag preview styling

* Fixed tooltip styling

* Removed unnecessary updates from block menu

* Vanilla example (#78)

* add vanilla example

* add bold toggle

* add other factories to vanilla example

* add dragging

* Updated naming for bubble, block, and hyperlink menus

* Fixed drag handle tests

* Fixed drag and drop tests

* Improved how UI element factories are passed to extensions

* Updated suggestions/slash menu naming

* Updated slash menu selector for tests

* Split factory params into static and dynamic

* Minor fix to `BNSetContentType()`

* Improved getting & setting block type in formatting toolbar factory API

* Minor typing fix

* Combined factory `update()` and `show()` functions into single `render()` function

* rename props -> staticParams in vanilla example

Co-authored-by: yousefed <[email protected]>
matthewlipski added a commit that referenced this pull request Feb 8, 2023
* upgrade to react 18

* Maybe fixed React error in build

* Added early implementation of bubble menu & editor in separate react package

* Moved all hyperlink menus to react package

* Major structural overhaul to menu factories

* Added suggestions menu factory with new (hopefully final) factory structure

* Refactored bubble menu code to use improved factory structure

* Changes to bubble menu code and documentation

* Changes to bubble menu code and documentation

* General improvements, mostly to bubble and hyperlink menus

* comments after call

* Split bubble menu props into init & update props
Moved animation delay timeout to bubble menu plugin

* clean up packaging

* fix react error

* Changed bubble menu plugin view back to use a separate class

* Split hyperlink menu props into init & update props

* Changed hyperlink menu plugin view to use a separate class

* fix gitignore

* fix tsconfig

* Major cleanup for bubble menu factory code

* Major cleanup for hyperlink menu factory code

* Minor fixes

* Converted suggestion plugin view to use a class

* Changed editor example to use React as before

* Improved file structure and minor tweaks

* Minor refactor

* Fixed hyperlink menu behaviour

* Separated drag handle UI elements to react package

* Separated drag handle UI elements to react package

* Minor improvements

* fix lint

* refactor entrypoints (#77)

* refactor entrypoints

* fix packages

* fix build

* move some more files / remove root.module.css

* Fixed hyperlink edit menu bugs

* re-add font

* Removed bubble menu animation update delay hack

* Changed bubble menu placement to be at the start of the selection bounding box

* Fixed hyperlink menu naming inconsistencies

* Refactored block/drag menu to use one factory and separate view class

* Fixed bubble menu sometimes attempting to hide when already hidden

* Fixed drag preview styling

* Fixed tooltip styling

* Removed unnecessary updates from block menu

* Vanilla example (#78)

* add vanilla example

* add bold toggle

* add other factories to vanilla example

* add dragging

* Updated naming for bubble, block, and hyperlink menus

* Fixed drag handle tests

* Fixed drag and drop tests

* Improved how UI element factories are passed to extensions

* Updated suggestions/slash menu naming

* Updated slash menu selector for tests

* Split factory params into static and dynamic

* Minor fix to `BNSetContentType()`

* Improved getting & setting block type in formatting toolbar factory API

* Minor typing fix

* Suggestions plugin refactor/rewrite

* Combined factory `update()` and `show()` functions into single `render()` function

* Changed item callback to delete both trigger character and query

* Minor fix

* rename props -> staticParams in vanilla example

* Changed suggestions menu behaviour when typing multiple "/" characters

* Minor change

* Fixed build error and placeholder when adding block using side menu

---------

Co-authored-by: yousefed <[email protected]>
fogle pushed a commit to fogle/BlockNote that referenced this pull request May 20, 2023
* upgrade to react 18

* Maybe fixed React error in build

* Added early implementation of bubble menu & editor in separate react package

* Moved all hyperlink menus to react package

* Major structural overhaul to menu factories

* Added suggestions menu factory with new (hopefully final) factory structure

* Refactored bubble menu code to use improved factory structure

* Changes to bubble menu code and documentation

* Changes to bubble menu code and documentation

* General improvements, mostly to bubble and hyperlink menus

* comments after call

* Split bubble menu props into init & update props
Moved animation delay timeout to bubble menu plugin

* clean up packaging

* fix react error

* Changed bubble menu plugin view back to use a separate class

* Split hyperlink menu props into init & update props

* Changed hyperlink menu plugin view to use a separate class

* fix gitignore

* fix tsconfig

* Major cleanup for bubble menu factory code

* Major cleanup for hyperlink menu factory code

* Minor fixes

* Converted suggestion plugin view to use a class

* Changed editor example to use React as before

* Improved file structure and minor tweaks

* Minor refactor

* Fixed hyperlink menu behaviour

* Separated drag handle UI elements to react package

* Separated drag handle UI elements to react package

* Minor improvements

* fix lint

* refactor entrypoints (TypeCellOS#77)

* refactor entrypoints

* fix packages

* fix build

* move some more files / remove root.module.css

* Fixed hyperlink edit menu bugs

* re-add font

* Removed bubble menu animation update delay hack

* Changed bubble menu placement to be at the start of the selection bounding box

* Fixed hyperlink menu naming inconsistencies

* Refactored block/drag menu to use one factory and separate view class

* Fixed bubble menu sometimes attempting to hide when already hidden

* Fixed drag preview styling

* Fixed tooltip styling

* Removed unnecessary updates from block menu

* Vanilla example (TypeCellOS#78)

* add vanilla example

* add bold toggle

* add other factories to vanilla example

* add dragging

* Updated naming for bubble, block, and hyperlink menus

* Fixed drag handle tests

* Fixed drag and drop tests

* Improved how UI element factories are passed to extensions

* Updated suggestions/slash menu naming

* Updated slash menu selector for tests

* Split factory params into static and dynamic

* Minor fix to `BNSetContentType()`

* Improved getting & setting block type in formatting toolbar factory API

* Minor typing fix

* Combined factory `update()` and `show()` functions into single `render()` function

* rename props -> staticParams in vanilla example

Co-authored-by: yousefed <[email protected]>
fogle pushed a commit to fogle/BlockNote that referenced this pull request May 20, 2023
* upgrade to react 18

* Maybe fixed React error in build

* Added early implementation of bubble menu & editor in separate react package

* Moved all hyperlink menus to react package

* Major structural overhaul to menu factories

* Added suggestions menu factory with new (hopefully final) factory structure

* Refactored bubble menu code to use improved factory structure

* Changes to bubble menu code and documentation

* Changes to bubble menu code and documentation

* General improvements, mostly to bubble and hyperlink menus

* comments after call

* Split bubble menu props into init & update props
Moved animation delay timeout to bubble menu plugin

* clean up packaging

* fix react error

* Changed bubble menu plugin view back to use a separate class

* Split hyperlink menu props into init & update props

* Changed hyperlink menu plugin view to use a separate class

* fix gitignore

* fix tsconfig

* Major cleanup for bubble menu factory code

* Major cleanup for hyperlink menu factory code

* Minor fixes

* Converted suggestion plugin view to use a class

* Changed editor example to use React as before

* Improved file structure and minor tweaks

* Minor refactor

* Fixed hyperlink menu behaviour

* Separated drag handle UI elements to react package

* Separated drag handle UI elements to react package

* Minor improvements

* fix lint

* refactor entrypoints (TypeCellOS#77)

* refactor entrypoints

* fix packages

* fix build

* move some more files / remove root.module.css

* Fixed hyperlink edit menu bugs

* re-add font

* Removed bubble menu animation update delay hack

* Changed bubble menu placement to be at the start of the selection bounding box

* Fixed hyperlink menu naming inconsistencies

* Refactored block/drag menu to use one factory and separate view class

* Fixed bubble menu sometimes attempting to hide when already hidden

* Fixed drag preview styling

* Fixed tooltip styling

* Removed unnecessary updates from block menu

* Vanilla example (TypeCellOS#78)

* add vanilla example

* add bold toggle

* add other factories to vanilla example

* add dragging

* Updated naming for bubble, block, and hyperlink menus

* Fixed drag handle tests

* Fixed drag and drop tests

* Improved how UI element factories are passed to extensions

* Updated suggestions/slash menu naming

* Updated slash menu selector for tests

* Split factory params into static and dynamic

* Minor fix to `BNSetContentType()`

* Improved getting & setting block type in formatting toolbar factory API

* Minor typing fix

* Suggestions plugin refactor/rewrite

* Combined factory `update()` and `show()` functions into single `render()` function

* Changed item callback to delete both trigger character and query

* Minor fix

* rename props -> staticParams in vanilla example

* Changed suggestions menu behaviour when typing multiple "/" characters

* Minor change

* Fixed build error and placeholder when adding block using side menu

---------

Co-authored-by: yousefed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant