You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could choose to keep react 17 compatibility, but as this library is in it's infancy, let's upgrade to v18 until we're sure non-17 compatibility is a breaking issue for users
@matthewlipski are you sure the move of deps fixes the build? I think the correct way would still be that React should be peerDeps instead of deps, and it seems like the failure of the test was due to a playwright error, not a build error, right?
@matthewlipski are you sure the move of deps fixes the build? I think the correct way would still be that React should be peerDeps instead of deps, and it seems like the failure of the test was due to a playwright error, not a build error, right?
Turns out I was wrong about playwright being the issue. The actual issue is a react version mismatch in the built environment, for which adding react dependencies in blocknote/core seems to fix. But you're right, it should read the peerDeps and figure out that react 18 is a requirement, yet after building, package-lock.json still includes a dependency on react 17 for blocknote/core. I don't know much about dependency management, so I'm not sure why this is happening, and this fix doesnt make much sense to me (since react isnt needed in blocknote/core), but it does indeed cause react 17 to stop showing up in package-lock.json.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade to react 18, closes #66
We could choose to keep react 17 compatibility, but as this library is in it's infancy, let's upgrade to v18 until we're sure non-17 compatibility is a breaking issue for users