Skip to content

Fixed dependency using require #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

matthewlipski
Copy link
Collaborator

The rehype-parse dependency hasn't been updated in a while and a sub-dependency, parse5, has moved from require to import statements in the meantime. This PR overrides parse5 to use a newer version so that Node JS is not required.

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocknote-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 10:56am

@matthewlipski
Copy link
Collaborator Author

So I hoped that this change could be implemented directly by rehype, but it doesn't seem to be the case. 2 PRs have already been created for this issue, but both are closed and marked "won't fix" (rehypejs/rehype#113 and rehypejs/rehype#129). The reason this issue won't get fixed is bc it's an issue with the packaging and not the imports themselves, though it does still mean that NodeJS is required.

I also tried updating the dependency myself in a fork of rehype (https://github.com/matthewlipski/rehype/tree/parse5-update), and a few tests fail. Not sure if we want to merge this change after all. @YousefED

@YousefED
Copy link
Collaborator

Closing issue until we can reproduce it

@YousefED YousefED closed this Jun 12, 2023
@YousefED
Copy link
Collaborator

Addressed in #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants