Fix build issue on custom-blocks-api-changes
#192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
maxswjeon
commented
May 12, 2023
|
Remaining type errors (for note)
|
|
Thanks for contributing @maxswjeon, and great to see you're getting up to speed with the codebase quickly. We're working hard on this feature as well so I think it's smart to make sure work does not overlap. Does #183 contain some of the suggestions already? |
|
Oh, I see. I will rebase to #183 and continue working. Thanks for pointing out. |
maxswjeon
force-pushed
the
custom-blocks-proposal
branch
from
b75cd5f to
25a0911
Compare
maxswjeon
changed the base branch from
custom-blocks-proposal
to
custom-blocks-api-changes
maxswjeon
changed the title
custom-blocks-api-changes
|
superseded by #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a first time opening a pull request in this project. I really appreciate your work, and I would like to provide some help if possible. I really want the custom blocks feature, so I am digging for it.
This PR is only for reference, so feel free to get some ideas and copy some codes.
The code might be not like your intentions. If so, please give short guidelines or your intensions so I can align with them.