Skip to content

fix: exclude non-table blocks from table handles #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nperez0111 merged 1 commit into from
May 15, 2025
Merged

fix: exclude non-table blocks from table handles #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/extensions/TableHandles/TableHandlesPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,7 @@ export class TableHandlesView<
this.state.block = this.editor.getBlock(this.state.block.id)!;
if (
!this.state.block ||
this.state.block.type !== "table" ||
// when collaborating, the table element might be replaced and out of date
// because yjs replaces the element when for example you change the color via the side menu
!this.tableElement?.isConnected
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/TableHandles/TableHandle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const TableHandle = <

const isDraggable = useMemo(() => {
const tableHandles = props.editor.tableHandles;
if (!tableHandles || !props.block) {
if (!tableHandles || !props.block || props.block.type !== "table") {
return false;
}

Expand Down
Loading