-
-
Notifications
You must be signed in to change notification settings - Fork 662
feat: add a ghost writer demo #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
@blocknote/xl-docx-exporter
commit: |
YousefED
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think good solution with the iframes.
- can we display the iframe url somewhere to make it easy to open a clean window with 1 client?
- I don't see awareness (cursors) of the ghost writers, is that missing?
- the preview environment (https://blocknote-git-simulate-multiple-users-typecell.vercel.app/collaboration/ghost-writer) seems to have a styling issue
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "playground": true, | |||
| "docs": true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be listed in docs - it's not a useful code snippet to learn from, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that was possible!
Cursors only display to clients when an editor is focused, so you won't see the cursors unless you are focused on a ghost writer, then the ghost writer cursor would show in the other editors.
I don't think I totally get what you are asking here. Are you wanting for the ghost writer to not start until you want (i.e. start paused)? Or are you asking for something else? |
52cf2a0 to
7de5271
Compare
This adds a demo which can simulate multiple users within the same document.
It uses partykit to connect to the same server, but generates a random room.
It allows instantiating multiple instances of the ghost writer.