Skip to content

fix: Selection when clicking past end of inline content #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: Selection when clicking past end of inline content #1553

merged 1 commit into from
Mar 25, 2025

Conversation

matthewlipski
Copy link
Collaborator

Closes #1523

@vercel Vercel
Copy link

vercel bot commented Mar 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 21, 2025 3:25pm
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 21, 2025 3:25pm

@YousefED
Copy link
Collaborator

Was this a recent regression / do you know what caused this to occur now?

nperez0111
nperez0111 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it'd be easy to overlook this

@matthewlipski
Copy link
Collaborator Author

Was this a recent regression / do you know what caused this to occur now?

We made some changes to CSS in #731, and removed flex-grow: 1 from .bn-block-content. I don't think there's a relevant difference between flex-grow: 1 and the changes in this PR.

@matthewlipski matthewlipski merged commit a0f5191 into main Mar 25, 2025
7 checks passed
@matthewlipski matthewlipski deleted the cursor-selection-end branch March 25, 2025 18:26
@NitanJana NitanJana mentioned this pull request Apr 9, 2025
Closed
1 task
@matthewlipski matthewlipski mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nperez0111 nperez0111 nperez0111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to insert the cursor at the end of the element inserts the cursor at the start
3 participants
@matthewlipski @YousefED @nperez0111