Require syslog only when necessary #248
Conversation
Requiring syslog on Ruby 3.3.0 results in an warning if the gem is not explicitly installed. Suppress it by requiring syslog only when the user tries to use Logging::Appender::Syslog.
|
Can we have this PR reviewed and merged? Need the warning resolution for syslog. |
|
It would be really great to get this one shipped to avoid these warnings in CI and soon breakage for users |
| @@ -1,18 +1,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
Along with this change, should this PR also include syslog in the gemspec file, as it will be removed from the default gems in Ruby 3.4.0 (currently outputs a console warning to that effect).
There was a problem hiding this comment.
This PR intentionally avoids including syslog in the gemspec file to avoid having an extra dependency for users who do not need Logging::Appender::Syslog.
Users who need Logging::Appender::Syslog should explicitly state that they need syslog by adding it to the gemspec files of their applications to prepare for Ruby 3.4.0.
4 participants
Requiring syslog on Ruby 3.3.0 results in an warning if the gem is not explicitly installed. Suppress it by requiring syslog only when the user tries to use Logging::Appender::Syslog.