-
Notifications
You must be signed in to change notification settings - Fork 16
Separate turing.ml site from Turing.jl #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
highest = maximum(highest_tags(versions)) | ||
@info "" baseurl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @debug instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'd rather be able to see it in the build logs without setting any other environment variables. It's pretty rare that this would be run by a human.
Seconded - this looks like a sensible separation between docs (Turing.jl and related libraries) and website (appearance, blog, news etc.).
To clarify a bit: does this mean the resulting output is pushed to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - thanks @cpfiffer! I left two minor questions in the comments section.
Not quite. Both |
* improve colors * better link hover color
* improve colors * better link hover color
* first part of new landing page (#1) * very basic redesign * make buttons interactive * Add code examples (#2) * add dangling code example * add code example section * Add news (#3) * quickfix alignment * add news and clean up scss * better alignment * add resources / "learn more" section * Improved colours (#4) * improve colors * better link hover color * better navbar text contrast * Add SVG header (#5) * paste in svg * responsive svg header * fix "learn more" hover text-deco * style team page for dark mode using the same background colour for the team "cards" as for the non-hoverable cards on the landing page * more relevant links at top of page - added links to discourse and slack to the buttons at the top of the page - moved link to libraries page to "Learn more" section * mirror gaussians and title * add css for code in dark mode * shorten footer for better fit on mobile * underline links in footer * responsive header size * content placeholders on landing page * Apply suggestions from code review Co-authored-by: Penelope Yong <[email protected]> * fix "logo" display by removing h1 * _quarto.yml: comments rewritten * Turned HTML to Quarto Markdown and added _includes to keep the main page clean * moved news to _included & added News section sliding animation * Improve news animation * removed new styles from this PR but added similar new theme in old format * Removed new styles of Simon, Updated tons of CSS to match new theme We will create new PR for Simon's new style * fixed search results color in dark mode * Added citations and commented placeholder text * fix new height & copy button css in dark mode * Updated News section to have fixed height & updated landing page codes * added arrows for moving forward and backward in news * Experiment another approach on news carousel * speeding news carousel * don't highlight tutorials button * update placeholder text * move tutorial button * fix unclosed div * fix buttons properly * polish text * delete whatever i wrote * fix unclosed div etc * refresh news * using quarto listing for news carousel * Updated news carousel * Mouse scroll in news works fine now * Updated lot of things, yet to remove news section * fix urls * Removed news section, added brands, improvded citations and other parts * added brands id * fix team theme in dark mode * trying custom page-layout * added side-space * fix libraries page in dark mode * few more fixes * brands text update * Add Alan Turing Institute Logo * fix ATI url * Add maX width as suggested by @simonsteiger * Add News and Tutorials on Landing Page * remove logo animation, add news and tuturials, add core packages, improve overall responsiveness * Updated logo and Added New Logo in Header * add on hover border on all boxes * fix colors in dark mode * Add custom footer, improve citations, fix responsiveness, update theme a bit * rewrite raw html in quarto markdown, update footer text, core package descriptions and few urls * update citation icons and footer text * Add on hover tooltip for citation icons * improve citations icon * Update header text * commit suggestions * apply suggestions * Minor Styling Fixes * save Cambridge University logo in assets * update .gitignore * dark mode news improvs * update my photo in team page * latest newsletter on landing page * fix search bar bg color in dark mode * drop css for scss + few style changes * add hover color for navbar items * minor design tweaks and fixes for news and libraries page + overall improvements * Add $body-bg for just in case we use it * Add code-block in What is Turing.jl? Section * experiment merging what is turing and header buttons * Add codeblock title * Update index.qmd Co-authored-by: Penelope Yong <[email protected]> * Update index.qmd Co-authored-by: Penelope Yong <[email protected]> * Update _quarto.yml Co-authored-by: Penelope Yong <[email protected]> * add tooltip css for dark mode * Add all social icons in navbar * add image for SEO * Enable Open Graph and Twitter Cards * Update _quarto.yml * add png, jpg logo and test open graph image * test open graph image * open graph test * open graph test * Open Graph ready! * CLEANUP * Remove hover effect from codeblock * Remove emojis from Start Your Journey Section --------- Co-authored-by: Simon Steiger <[email protected]> Co-authored-by: simonsteiger <[email protected]> Co-authored-by: Penelope Yong <[email protected]>
This PR makes it so that the build process for
turing.ml
is distinct from Turing.jl. Currently, all the website files live inside Turing'sdocs
folder, which has various disadvantages.Most of the work in the PR shows up in
make.jl
and a little bit inmake-utils.jl
. Everything else is largely copied over fromTuring.jl/docs
. To summarize the new build process:master
of Turing, and then rebuilds whatever the most recent released version is.make.jl
will build the site in a temporary folder and copy all the relevant documents to it. Documenter.jl deploys the docs from this temporary folder.The idea is to keep everything that needs to be "stateful" in Turing.jl, such as the guides and documentation, and everything that always needs to be current (like the blog or list of team members) in this repo. We also don't really want to have much/any HTML in Turing.jl, which this PR also handles. I will remove all the stuff we don't need in Turing once this repo is functional.
Note that this won't actually change the site when the PR goes through, since GitHub is still configured to serve the site from Turing.jl. I assume there will also be some headaches as we transition over, but I won't know until we merge this in.