Set minimum of OrderedLogistic distribution to 1 #2603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum of the OrderedLogistic function is supposed to be 1, not 0. This is consistent with the documentation, and the behavior of the distribution when using rand().
|
That's great, thanks! Could I trouble you to add a test to |
|
I can try later today! |
We add the test that the support should have the right number of elements, and that the probabilities add up to 1.0.
|
Added a test now. |
|
Wonderful, thank you for the great work @Noricc! I'll just bump the patch so that we can release, then will merge once CI is happy. |
penelopeysm
force-pushed
the
orderedlogistic-fix
branch
from
863acef to
2a2bd6b
Compare
penelopeysm
approved these changes
Jun 26, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
=======================================
Coverage 85.57% 85.57%
=======================================
Files 22 22
Lines 1456 1456
=======================================
Hits 1246 1246
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 15899880826Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum of the OrderedLogistic distribution is supposed to be 1, not 0. This is consistent with the documentation, and the behavior of the distribution when using rand().
Fixes bug #2602