Skip to content

Conversation

penelopeysm
Copy link
Member

Part of addressing #2515

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (e4cd6a2) to head (e9c8413).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2518   +/-   ##
=======================================
  Coverage   86.03%   86.04%           
=======================================
  Files          21       21           
  Lines        1454     1455    +1     
=======================================
+ Hits         1251     1252    +1     
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14087341066

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 86.048%

Totals Coverage Status
Change from base Build 13945146446: 0.009%
Covered Lines: 1252
Relevant Lines: 1455

💛 - Coveralls

@penelopeysm penelopeysm requested a review from Copilot March 26, 2025 18:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new release note for version 0.37.1 that documents the introduction of the new check_model argument for optimisation, addressing issue #2515.

  • Adds release documentation for new sanity checks in maximum_a_posteriori and maximum_likelihood functions.
  • Provides instructions on how to disable the model checks via the check_model parameter.
Files not reviewed (2)
  • src/optimisation/Optimisation.jl: Language not supported
  • test/optimisation/Optimisation.jl: Language not supported

@penelopeysm
Copy link
Member Author

I didn't know you can now request AI reviews 😅😅😅

@penelopeysm penelopeysm requested a review from sunxd3 March 27, 2025 17:03
Copy link
Member

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunxd3
Copy link
Member

sunxd3 commented Mar 27, 2025

Am I AI? 😄

@penelopeysm
Copy link
Member Author

Actual Intelligence ;)

@penelopeysm penelopeysm merged commit afb5c44 into main Mar 27, 2025
47 checks passed
@penelopeysm penelopeysm deleted the py/optim-check branch March 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants