Skip to content

Conversation

@brody4hire
Copy link

@brody4hire brody4hire commented Dec 3, 2021

updated:

I think this needs a new 0.x version due to the nature of switching to Webpack v5.

Motivation:

I had to apply an ugly workaround to get react-recompose CI working on Node.js 17, would like to get it fixed in this Rollup plugin if possible.

I would be happy to break this down to multiple PRs or combine some of the proposed commits if needed to get this reviewed and hopefully merged.

Thanks in advance!

Christopher J. Brody added 14 commits December 2, 2021 19:57
(jest-matcher-deep-close-to v3)

with a Webpack treeshake test case

as needed due to variation of Webpack treeshake variation
between Linux, Windows, and macOS

known to be needed with both Webpack v4 & recent Webpack v5 releases
* add GitHub workflow for Node.js CI testing from template,
  with some updates:
  - switch to Yarn
  - remove use of npm cache
  - always do npm run build
  - update workflow name
  - move comment for node-version
* update variation in "handle umd with esm" case
* use matrix to for CI build on Ubuntu, Windows, macOS
* expand node-version list & add TODO comment
* cleanup some comments
* remove .travis.yml

ref: #1
@brody4hire brody4hire mentioned this pull request Dec 7, 2021
9 tasks
Christopher J. Brody added 4 commits December 7, 2021 12:26
update 2 test cases for Rollup 2.0.0, 2.10.x vs 2.60.x
which seems to be already covered by `yarn` installation command
@brody4hire
Copy link
Author

brody4hire commented Dec 30, 2021

@TrySound is there any chance you would be willing to consider some of the updates that I had proposed?

Is there anything we can do to help make this happen?

I would be happy to split this into multiple PRs if needed.

I did start maintaining my own fork to solve an issue with testing react-recompose on Node.js 17, hope it can go away (someday).


Thanks in advance for your consideration.

I think the most important things are to get this working with GitHub CI workflows and update to Webpack 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant