-
-
Notifications
You must be signed in to change notification settings - Fork 846
Add generic type annotations for Statement and Database get/all/each methods callback rows #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daniellockyer
merged 2 commits into
TryGhost:master
from
stevescruz:stevescruz/add-generic-type-definitions-for-callback-rows
Mar 13, 2023
Merged
Add generic type annotations for Statement and Database get/all/each methods callback rows #1686
daniellockyer
merged 2 commits into
TryGhost:master
from
stevescruz:stevescruz/add-generic-type-definitions-for-callback-rows
Mar 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent methods -For get method callback's row -For all method callback's rows -For each method callback's row
…se methods -For get method callback's row -For all method callback's rows -For each method callback's row
Contributor
Author
|
@daniellockyer thanks for running the CI pipeline. |
Contributor
|
@stevescruz Nice, thanks! |
This was referenced Sep 27, 2024
This was referenced Oct 3, 2024
This was referenced Oct 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small change, but some developers enjoy working with generics over the
anytype when using TypeScript.Added Generics type annotations for the following methods:
Statement.getStatement.allStatement.eachDatabase.getDatabase.allDatabase.eachBackwards Compatibility
This will not break existing TypeScript code. It will still be possible to directly add type annotations to the row/rows.
Examples:
Take into consideration the following TypeScript code:
How type annotations currently works:
NOTE: this will still work after the code changes.
Now you will be able to: