Is calling "return super.proxify(this);" in constructror a good idea?

[omatrot]

I'm trying to target es6 with my typescript entities.

The code fails at runtime.

Couls you have a look at this answer on Stack Overflow and tell me what you think ?

No error with es5 target.

[tonysneed]

The reason you are not getting an error with es5 is that it does not support es proxies. For that you will need es2015 or later.

Is this error the result of using Dcerialize for serialization? If so, it's because properties are being set before the ctor has been called.

As mentioned in this issue, the alternative is to call the public static proxify method and remove return super.proxify(this); from the ctor of your generated entities.

[omatrot]

Yes, this is the result of using Dcerialize for deserialization:

const datis: Vehicule[] = DeserializeArray(
            message.listDatiOfCompany,
            () => Vehicule
          ); 

How would I call the static proxify method? I've tried doing it after the call above:

const proxifiedDatis = datis.map(v => ObservableEntity.proxify(v));
But this does not compile:

error TS2345: Argument of type 'Vehicule' is not assignable to parameter of type 'new () => {}'.
Type 'Vehicule' provides no match for the signature 'new (): {}'.

[tonysneed]

You need to have a ctor in the entity, just remove return super.proxify(this) from the ctor. The rest of the ctor can remain.

[omatrot]

You need to have a ctor in the entity, just remove return super.proxify(this) from the ctor. The rest of the ctor can remain.

This is exactly what I've done, all the constructors are now:

 constructor() {
    super();
    //return super.proxify(this);
  }

[tonysneed]

You need to pass the entity ctor. Does this work?

const foo = ObservableEntity.proxify(Vehicule);

[omatrot]

Yep, How stupid was I to pass an instance?

[tonysneed]

You can also get the entity ctor using an instance.

const foo = ObservableEntity.proxify(Object.getPrototypeOf(v).constructor);

[omatrot]

I'm afraid the issue is not what I think it is...
My problem is not solved, it seems that this is tied to the way that webpack transpiles exported classes into modules.
This is the generated code that fails.

[omatrot]

Solved
I'm back to ES5 and specifying InstantiationMethod explicitely.

const datis: Vehicule[] = DeserializeArray(
            message.listDatiOfCompany,
            () => Vehicule,
            undefined,
            undefined,
            undefined,
            InstantiationMethod.ObjectCreate
          ); 

EDIT : This means that I have to call the poxify method explicitely though.