fix type issue #40
Open
fix type issue #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Nitish @nitishsrivastava
I was inaccurate with types here, imread() reads image in the format CV_8UC3, which means 3 channels unsigned char. This code works with my tests when I implemented it, so I missed it, but recently I fixed this in my code, there it leads to incorrect behaviour. I didn't test much it here now, but anyway I should point out on possible issue. Sorry if this type mismatch leads to incorrect work of code.
I also made minor updates in the install document.
WBR,
Dmitriy