Add unit tests for Base64 and Charsetfunctions #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipRoman
reviewed
Aug 12, 2019
src/test/java/org/java_websocket/util/CharsetfunctionsTest.java
Outdated
Show resolved
Hide resolved
ThomasPerkins1123
force-pushed
the
add-diffblue-tests
branch
from
a3054aa to
4342f41
Compare
These tests were written using Diffblue Cover.
ThomasPerkins1123
force-pushed
the
add-diffblue-tests
branch
from
4342f41 to
10b5d2b
Compare
Contributor
Author
|
@marci4 Done! |
marci4
approved these changes
Sep 8, 2019
Collaborator
|
@PhilipRoman you're good with the changes? |
Collaborator
|
Yeah, sure |
Collaborator
|
@PhilipRoman thx! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
I've analysed your code base and noticed that
org.java_websocket.util.Base64andorg.java_websocket.util.Charsetfunctionsare not fully tested.I've written some tests that cover these classes with the help of Diffblue Cover.
Motivation and Context
Hopefully, these tests should help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other particular classes that you consider important.
Types of changes
Checklist: