Question: How can the compression threshold be set for the PerMessageDeflateExtension in a Deflate Client?

[CommuniG8]

Describe what you would like to know or do
I'd like to be able to set the compression threshold to a lower value than the 1024 byte value in the PerMessageDeflateExtension.

Describe the solution you'd considered
I've taken a copy of the 1.5.7 source code and changed the default threshold which does work but this is not ideal.

Additional context
I'm sending messages which are a little smaller than 1024 bytes that I'd like to compress.

[PhilipRoman]

setThreshold should do what you want

[CommuniG8]

Could you give an example of using that method please?

[CommuniG8]

It's not obvious how it should be called.

[marci4]

Question is answered

[PhilipRoman]

Actually I am not sure it is solved - from a brief look I didn't see a way for user to access the internal objects. But at the moment I don't have a lot of time and this is a low priority issue. It's possible we need to add a setter for this.

[marci4]

What internal classes do you mean?

[marci4]

Oh I see the problem. The values are not correctly cloned.
https://github.com/TooTallNate/Java-WebSocket/blob/master/src/main/java/org/java_websocket/extensions/permessage_deflate/PerMessageDeflateExtension.java#L333

Looking into copyInstance(), the fix for us for the specific issue is easy.
The problem however is that setInflater/setDeflater.

@PhilipRoman I think about removing setInflater/setDeflater and replace them with a specific factory which the user can provide if they want to.
The setter never worked and therefore I dont think we break many existing applications.
What do you think?