Feat: Add support for concurrent table diff across all impacted models #4256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
reviewed
Apr 25, 2025
| @@ -197,7 +197,7 @@ def show_intervals(self, snapshot_intervals: t.Dict[Snapshot, SnapshotIntervals] | |||
|
|
|||
|
|
|||
| class DifferenceConsole(abc.ABC): | |||
| """Console for displaying environment differences""" | |||
| """Console for displaying differences""" | |||
There was a problem hiding this comment.
@benfdking is this how you intended for this interface to be used?
izeigerman
reviewed
Apr 25, 2025
sqlmesh/core/context.py
Outdated
| ) | ||
|
|
||
| table_diffs: t.List[TableDiff] = [] | ||
| with ThreadPoolExecutor( |
There was a problem hiding this comment.
There was a problem hiding this comment.
yes good point
izeigerman
reviewed
Apr 25, 2025
sqlmesh/core/context.py
Outdated
|
|
||
| def run_diff(snapshot_name: str) -> TableDiff: | ||
| return self.table_diff( | ||
| source=source, |
There was a problem hiding this comment.
So are we going to fetch both environments N more times where N is the number of snapshots that are different?
There was a problem hiding this comment.
you're right didn't realise that, I should refactor this so it doesn't call table_diff or break it up into methods to guarantee nothing is called twice
themisvaltinos
force-pushed
the
themis/diff
branch
from
be32e55 to
f9124c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for the first point in this issue: #4198
When using the table_diff command without specifying a model
sqlmesh table_diff source:prodit diffs all models impacted directly or indirectly. It does this by using the context diff between the two environments to identify affected models, then runs table_diff in each to determine which tables have changed and finally display the corresponding table diffs.