Fix: Enviroment & snapshot cleanup order #4228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaggelisD
changed the title
VaggelisD
force-pushed
the
vaggelisd/snapshot_deletion
branch
2 times, most recently
from
89d76c4 to
14d63c2
Compare
VaggelisD
commented
Apr 23, 2025
izeigerman
reviewed
Apr 23, 2025
izeigerman
reviewed
Apr 23, 2025
izeigerman
reviewed
Apr 23, 2025
izeigerman
reviewed
Apr 23, 2025
izeigerman
reviewed
Apr 23, 2025
izeigerman
reviewed
Apr 25, 2025
izeigerman
reviewed
Apr 25, 2025
izeigerman
reviewed
Apr 25, 2025
izeigerman
reviewed
Apr 25, 2025
VaggelisD
force-pushed
the
vaggelisd/snapshot_deletion
branch
from
8ef41bf to
3b9ba12
Compare
izeigerman
reviewed
Apr 28, 2025
izeigerman
reviewed
Apr 28, 2025
|
I believe this PR would fix the following reported issues in the slack channel: |
izeigerman
approved these changes
Apr 28, 2025
VaggelisD
force-pushed
the
vaggelisd/snapshot_deletion
branch
from
d9b88f3 to
c0b365f
Compare
VaggelisD
force-pushed
the
vaggelisd/snapshot_deletion
branch
from
c0b365f to
415f2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4055
This PR changes the order of deletions so that the actual views & physical tables are deleted before their state sync entries; This ensures that if the former fails, the state sync is not modified and a future
sqlmesh janitorcan pick up again the expired snapshots & environments on a later invocation.