Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scripts/__tests__/server.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import getConfig from '../config';
jest.mock('../create-server', () => () => {
return {
app: {
listen: (port: number, host: string, cb: () => void) => cb(),
startCallback: (cb: () => void) => cb(),
close: (cb: () => void) => cb(),
},
compiler: {},
Expand All @@ -19,6 +19,6 @@ test('server should return an object containing a server instance', () => {
expect(callback).toBeCalled();
expect(serverInfo.app).toBeTruthy();
expect(serverInfo.compiler).toBeTruthy();
expect(typeof serverInfo.app.listen).toBe('function');
expect(typeof serverInfo.app.startCallback).toBe('function');
expect(typeof serverInfo.app.close).toBe('function');
});
34 changes: 22 additions & 12 deletions src/scripts/create-server.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import webpack, { Configuration } from 'webpack';
import WebpackDevServer from 'webpack-dev-server';
import merge from 'webpack-merge';
import webpack from 'webpack';
import WebpackDevServer, { Configuration } from 'webpack-dev-server';
import makeWebpackConfig from './make-webpack-config';
import * as Rsg from '../typings';

Expand All @@ -10,26 +9,37 @@ export default function createServer(
): { app: WebpackDevServer; compiler: webpack.Compiler } {
const webpackConfig = makeWebpackConfig(config, env);

const baseConfig = {
const baseConfig: Partial<Configuration> = {
host: config.serverHost,
port: config.serverPort,
compress: true,
hot: true,
client: {
logging: 'none',
},
static: {
directory: config.assetsDir,
watch: config.assetsDir !== undefined,
publicPath: '/',
},
static: Array.isArray(config.assetsDir)
? config.assetsDir.map((assetsDir) => ({
directory: assetsDir,
watch: true,
publicPath: '/',
}))
: {
directory: config.assetsDir,
watch: true,
publicPath: '/',
},
devMiddleware: {
stats: webpackConfig.stats || {},
},
} as Configuration;
};

const webpackDevServerConfig = merge(baseConfig, webpackConfig.devServer as Configuration);
const webpackDevServerConfig: Configuration = {
...webpackConfig.devServer,
...baseConfig,
};

const compiler = webpack(webpackConfig);
const devServer = new WebpackDevServer(compiler, webpackDevServerConfig);
const devServer = new WebpackDevServer(webpackDevServerConfig, compiler);

// User defined customizations
if (config.configureServer) {
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default function server(
const env = 'development';
const serverInfo = createServer(config, env);

serverInfo.app.listen(config.serverPort, config.serverHost, callback);
serverInfo.app.startCallback(callback);

return serverInfo;
}