Sensocon Product Addition #944
Conversation
|
|
|
Hi @jenkinsheath thank you for contributing, there are some fixes to do on your files, please take a look to the comments I made on them. |
There was a problem hiding this comment.
There is a vendor index.yaml file where you have to add Sensocon information. vendor/index.yaml . This file should not be here.
| @@ -0,0 +1,35 @@ | |||
| name: WS-AI Analog 4-20mA Current Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
There was a problem hiding this comment.
Jaime, thanks for taking the time to review so quickly. I am attempting to access the partners page and get a "Something went wrong" Please refresh the page and try again". Tried different browsers and connections, no luck. Are you familiar with the problem and resolution on this partner device page?
| @@ -0,0 +1,36 @@ | |||
| name: WS-DP Differential Pressure Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
| @@ -0,0 +1,35 @@ | |||
| name: WS-G Gauge Pressure Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
| @@ -0,0 +1,37 @@ | |||
| name: WS-HT Humidity + Temperature Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
| @@ -0,0 +1,35 @@ | |||
| name: WS-TI Temperature Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
| @@ -0,0 +1,36 @@ | |||
| name: WS-VI Analog Voltage Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
| @@ -0,0 +1,36 @@ | |||
| name: WS-W Wet/Wet Differential Pressure Sensor | |||
| description: >- | |||
There was a problem hiding this comment.
Description should be short and precise, take out the example lines, once merged this will be displayed in the partners devices webpage take a look to see some examples of descriptions.
| hardwareVersions: | ||
| - version: 90309-1 | ||
| firmwareVersions: | ||
| - version: AA |
There was a problem hiding this comment.
profiles are necessary in this file, take a look to the vendor/example windsensor.yaml file. This apply to all the devices files in your PR
There was a problem hiding this comment.
Jaime, first time uploading to the repository, appreciate your patience. Can I use a single default profile, as all of our units are currently using the same profile? I see that some vendors seem to do this.
|
@jenkinsheath the |
|
Hi @jenkinsheath I will close this PR, feel free to open it again and make the needed changes so we can merge it. Thanks |
3 participants
Summary
Adding Sensocon WS series LoRaWAN sensor devices to the repository....
Changes
profileIDsshould not bevendorIDand should be a unique value for every profile.index.yamlfile.Notes for Reviewers
...
Release Notes