Replace generator-exercise with plop generator #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wise-king-sullyman
previously approved these changes
Mar 2, 2024
Member
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Couple of small non-blocking nits, but I love this.
generators/writeExercise.js
Outdated
| }; | ||
|
|
||
| // Do not edit below this line | ||
| module.exports = ${exerciseName};`; |
Member
There was a problem hiding this comment.
Nit: a newline at the end of all of these would be nice
Comment on lines
+4
to
+7
| const { createExerciseDirectoryName } = require("./generators/helpers"); | ||
| const { writeReadme } = require("./generators/writeReadme"); | ||
| const { writeExercise } = require("./generators/writeExercise"); | ||
| const { writeExerciseSpec } = require("./generators/writeExerciseSpec"); |
Member
There was a problem hiding this comment.
Super nit: I would maybe throw all of the generator functions into a barrel file to tidy up the imports here.
thatblindgeye
force-pushed
the
plopGenerator
branch
from
c950848 to
ffe7f14
Compare
wise-king-sullyman
approved these changes
Mar 3, 2024
Oussama5379
added a commit
to Oussama5379/javascript-exercises
that referenced
this pull request
Feb 1, 2025
Replace generator-exercise with plop generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
generator-exercise hasn't really been used. Replacing it with plop makes it more straightforward to create new exercises
This PR
Issue
Closes #XXXXX
Additional Information
I'd also be fine with just removing generator-exercise with no replacement if it just doesn't make sense to have a generator.
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder